On Tue, Mar 10, 2015 at 4:08 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Friday 20 February 2015 19:01:10 Maxime Coquelin wrote: >> +/* Pull-Up/Down */ >> +#define NO_PULL 0 >> +#define PULL_UP 1 >> +#define PULL_DOWN 2 >> + >> +/* Type */ >> +#define PUSH_PULL (0 << 2) >> +#define OPEN_DRAIN (1 << 2) >> + > > These should probably not be stm32 specific at all, they sound > rather generic, so maybe put the definitions into a common file. It's part of what GENERIC_PINCONF does and it has bindings in Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html