On 06/09/2024 17:15, Raviteja Laggyshetty wrote: > QCS8300 SoC has several bus fabrics that could be controlled > and tuned dynamically according to the bandwidth demand. You got quite precise review about subject, which you partially implemented and then added something more redundant. Look, this is supposed to be device name. Add QCS8300 RPMh NoC. Drop redundant information. > > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@xxxxxxxxxxx> > --- > .../interconnect/qcom,qcs8300-rpmh.yaml | 72 +++++++ > .../interconnect/qcom,qcs8300-rpmh.h | 189 ++++++++++++++++++ > 2 files changed, 261 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml > create mode 100644 include/dt-bindings/interconnect/qcom,qcs8300-rpmh.h > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml > new file mode 100644 > index 000000000000..2759b003ebcf > --- /dev/null > +++ b/Documentation/devicetree/bindings/interconnect/qcom,qcs8300-rpmh.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interconnect/qcom,qcs8300-rpmh.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. RPMh Network-On-Chip Interconnect on QCS8300 Isn't this just "Qualcomm"? How is in most of other bindings? I asked not to send us your downstream stuff. I said it about driver, though... so repeat here: Do not send downstream code, but work on upstream and use upstream style. This applies to all patches: drivers, DTS, bindings, everything. So which upstream binding was used as template for this one here? Best regards, Krzysztof
