On 9/6/24 12:42 AM, Nuno Sá wrote: > On Thu, 2024-09-05 at 14:19 -0500, David Lechner wrote: >> On 9/5/24 10:17 AM, Angelo Dureghello wrote: >>> From: Angelo Dureghello <adureghello@xxxxxxxxxxxx> >>> >>> Change to obtain the fdt use case as reported in the >>> adi,ad3552r.yaml file in this patchset, with the DAC device that >>> is actually using the backend set as a child node of the backend. >>> >>> To obtain this, registering all the child fdt nodes as platform >>> devices. >>> >>> Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx> >>> Co-developed-by: David Lechner <dlechner@xxxxxxxxxxxx> >>> Co-developed-by: Nuno Sá <nuno.sa@xxxxxxxxxx> >>> --- >>> drivers/iio/dac/adi-axi-dac.c | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/drivers/iio/dac/adi-axi-dac.c b/drivers/iio/dac/adi-axi-dac.c >>> index cc31e1dcd1df..e883cd557b6a 100644 >>> --- a/drivers/iio/dac/adi-axi-dac.c >>> +++ b/drivers/iio/dac/adi-axi-dac.c >>> @@ -783,6 +783,7 @@ static int axi_dac_probe(struct platform_device *pdev) >>> { >>> struct axi_dac_state *st; >>> const struct axi_dac_info *info; >>> + struct platform_device *child_pdev; >>> void __iomem *base; >>> unsigned int ver; >>> struct clk *clk; >>> @@ -862,6 +863,20 @@ static int axi_dac_probe(struct platform_device *pdev) >>> return dev_err_probe(&pdev->dev, ret, >>> "failed to register iio backend\n"); >>> >>> + device_for_each_child_node_scoped(&pdev->dev, child) { >> >> This should use fwnode_for_each_available_child_node() so that it skips >> nodes with status != "okay". >> > > device_for_each_child_node() already only looks at available nodes IIRC > > - Nuno Sá > Ah, you are right, I did not dig deep enough.