Hi Binbin, On Thu, Sep 5, 2024 at 9:07 AM Binbin Zhou <zhoubinbin@xxxxxxxxxxx> wrote: > The Loongson I2S controller exists not only in PCI form (LS7A bridge > chip), but also in platform device form (Loongson-2K1000 SoC). > > This patch adds support for platform device I2S controller. > > Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx> Thanks for your patch! > --- a/sound/soc/loongson/Kconfig > +++ b/sound/soc/loongson/Kconfig > @@ -13,10 +13,20 @@ config SND_SOC_LOONGSON_I2S_PCI > The controller is found in loongson bridge chips or SoCs, > and work as a PCI device. > > +config SND_SOC_LOONGSON_I2S_PLATFORM > + tristate "Loongson I2S controller as platform device" depends on LOONGARCH || COMPILE_TEST > + select SND_SOC_GENERIC_DMAENGINE_PCM > + help > + Say Y or M if you want to add support for I2S driver for > + Loongson I2S controller. > + > + The controller work as a platform device, found in loongson > + SoCs. > + > config SND_SOC_LOONGSON_CARD > tristate "Loongson Sound Card Driver" > select SND_SOC_LOONGSON_I2S_PCI > - depends on PCI "select SND_SOC_LOONGSON_I2S_PCI if PCI"? > + select SND_SOC_LOONGSON_I2S_PLATFORM Or perhaps do it the other way around, i,e. let SND_SOC_LOONGSON_I2S_{PCI,PLATFORM} select SND_SOC_LOONGSON_CARD? That would be similar to SPI_LOONGSON_{PCI,PLATFORM}, which select SPI_LOONGSON_CORE. > help > Say Y or M if you want to add support for SoC audio using > loongson I2S controller. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds