On Tue, Mar 17, 2015 at 12:30:32PM -0700, Brian Norris wrote: > There were regressions seen with commit 106937e8ccdc ("of: fix handling > of '/' in options for of_find_node_by_path()"), where we couldn't handle > extra '/' before the ':'. Let's test for this now. > > Confirmed that this test fails without the previous patch and passes > when patched. All other tests pass. > > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> > --- > drivers/of/unittest.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index aba8946cac46..52c45c7df07f 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -97,6 +97,11 @@ static void __init of_selftest_find_node_by_name(void) > "option path test, subcase #1 failed\n"); > of_node_put(np); > > + np = of_find_node_opts_by_path("/testcase-data/testcase-device1:test/option", &options); > + selftest(np && !strcmp("test/option", options), > + "option path test, subcase #2 failed\n"); > + of_node_put(np); > + > np = of_find_node_opts_by_path("/testcase-data:testoption", NULL); > selftest(np, "NULL option path test failed\n"); > of_node_put(np); > -- > 1.9.1 Acked-by: Leif Lindholm <leif.lindholm@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html