On Thu, Sep 05, 2024 at 03:02:54PM +0800, Binbin Zhou wrote: > This patch attempts to clean up driver code formatting issues. > Mainly as follows: > 1. Use the BIT macro; > 2. Use dev_err_probe() in every error path in probe in loongson_card > driver; > 3. Introduce loongson_card_acpi_find_device() to streamlined code. Please split these out into three separate patches to make them easier to review. I see there's also some other code reordering and reformatting in there which should also be split out separately. I think the changes are probably good overall but there's too much different stuff going on in one patch to check properly.
Attachment:
signature.asc
Description: PGP signature