Hi, On 14.08.2024 16:22, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 14/08/2024 14:26, Andrei Simion wrote: >> Rename the usb node according to devicetree >> specification and update the label according >> with the node-specific standard as: ohci, ehci >> or gadget. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > ... > In V2 I will wrap the commit message according to Linux coding style / submission process > >> >> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts >> index 742fcf525e1b..52e166c8a365 100644 >> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts >> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts >> @@ -50,13 +50,13 @@ macb0: ethernet@fffc4000 { >> status = "okay"; >> }; >> >> - usb1: gadget@fffa4000 { >> + gadget: usb@fffa4000 { >> atmel,vbus-gpio = <&pioC 15 GPIO_ACTIVE_HIGH>; >> status = "okay"; >> }; >> }; >> >> - usb0: ohci@500000 { >> + ohci: usb@500000 { > > I don't think that these label renames are correct. > I checked in other dts dtsi (other silicon vendors) the USB node and it uses ohci, ehci, gadget, etc as a label. Also, I verified the address in the datasheet and they are correctly labeled (meant that they were: usb gadget, usb ohci, usb ehci)
