On Thu, Sep 05, 2024 at 08:15:40AM GMT, Rob Herring wrote: > On Thu, Sep 5, 2024 at 2:46 AM Thomas Weißschuh > <thomas.weissschuh@xxxxxxxxxxxxx> wrote: > > > > The members "start" and "end" of struct resource are of type > > "resource_size_t" which can be 32bit wide. > > Values read from OF however are always 64bit wide. > > Avoid silently truncating the value and instead return an error value. > > > > This can happen on real systems when the DT was created for a > > PAE-enabled kernel and a non-PAE kernel is actually running. > > For example with an arm defconfig and "qemu-system-arm -M virt". > > A nice follow-up would be to make of_pci_range_to_resource() use > overflows_type() as well instead of open coding it. Good catch. There are some differences though, it * returns -EINVAL on overflow instead of -EOVERFLOW * sets ->start and ->end to OF_BAD_ADDR on overflow * does not check ->end for overflow I don't have much experience with OF, so I'm not sure which of these are important and if overflow checks on intermediate calculations are also necessary.
