Hello Krzysztof,
On 2024-09-05 13:39, Krzysztof Kozlowski wrote:
On 05/09/2024 13:32, Dragan Simic wrote:
Sprinkle a few commonly used aliases onto the PineTab2 dtsi file, to
improve
its readability a bit, to make it easier to refer to the actual nodes
later,
if needed, and to add a bit more detail to some of the labels.
No functional changes are introduced, which was validated by
decompiling and
comparing all affected board dtb files before and after these changes.
When
compared with the decompiled original dtb files, some of the phandles
in the
updated dtb files have different values, and the updated dtb files
contain
some additional phandles and additional symbols that come from the
introduced
aliases, but they still effectively remain the same as the originals.
Suggested-by: Diederik de Haas <didi.debian@xxxxxxxxx>
Signed-off-by: Dragan Simic <dsimic@xxxxxxxxxxx>
---
Unused aliases do not improve readability, so for me this change is
making code worse without valid reason.
Then why do we already have, for example, unused "rk817_charger:
charger"
aliases in quite a few board dts(i) files? If those are actually seen
as
redundant, we should remove all of them.
