Re: [PATCH can-next v5 00/20] can: rockchip_canfd: add support for CAN-FD IP core found on Rockchip RK3568

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04.09.2024 10:55:21, Heiko Stübner wrote:
> Hi Marc,
> 
> Am Mittwoch, 4. September 2024, 10:12:44 CEST schrieb Marc Kleine-Budde:
> > This series adds support for the CAN-FD IP core found on the Rockchip
> > RK3568.
> > 
> > The IP core is a bit complicated and has several documented errata.
> > The driver is added in several stages, first the base driver including
> > the RX-path. Then several workarounds for errata and the TX-path, and
> > finally features like hardware time stamping, loop-back mode and
> > bus error reporting.
> > 
> > regards,
> > Marc
> > 
> > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> 
> I have neither CAN knowledge, nor hardware to test, but the integration
> itself looks pretty easy and straight-forward.
> 
> Not sure how much it helps, but at this moment I assume you know what
> you're doing with respect to the CAN controller ;-)

I hope so :) The controller has some flaws :/

> Rest of the series (that hasn't got a Rb):
> 
> Acked-by: Heiko Stuebner <heiko@xxxxxxxxx>

Thanks.

> How/when are you planning on applying stuff?
> 
> I.e. if you're going to apply things still for 6.12, you could simply take
> the whole series if the dts patches still apply to your tree ;-)

Actually I've already started my PR workflow, but I'll address your
review feedback, add your tags and send a new PR today. This will go via
net-next into v6.12.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux