On 2024/8/30 19:20, Inochi Amaoto wrote:
On Fri, Aug 30, 2024 at 10:06:45AM GMT, Thomas Bonnefille wrote:
[......]
Have you test you patch with a real board? Especially
for device "uart1" and "i2c0", I suspect your
configuartion does not work by default.
Hi, Thomas Bonnefille,
Can you please double check and feedback, I want to confirm this before
acking this change.
As you know, rc6 will come next week and I'm planning a pr next week.
Regards,
Chen
Hello Chen and Inochi,
I'm really sorry, indeed, those nodes certainly don't work, it was a mistake
on my side introduced between v1 and v2.
However, I can ensure that "uart0" and "sdhci0" are working fine.
May I suggest to remove those two nodes? I can send a new iteration if it's
easier for you to handle?
As you need a new version, please add pinctrl node and necessary pin
configuration. And I will take the first two binding patch. So there
is no need to add them anymore.
The pinctrl patch (note it also needs a dependency):
https://lore.kernel.org/all/IA1PR20MB4953DC78BB0FE0C57EA94F91BBB32@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
Regard,
Inochi
FYI,
https://lore.kernel.org/linux-riscv/MA0P287MB28228F4FC59B057DF57D9A11FE9C2@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/,
I have raised a PR and included the two bindings related patches.
Thomas Bonnefille, for other DTS part, please go ahead and post new
version with your changes, I will raise PR after your update.
Regards,
Chen
