On 9/3/24 17:45, Krzysztof Kozlowski wrote: > On 03/09/2024 14:44, Ivaylo Ivanov wrote: >> Hi folks, >> >> This series adds initial SoC support for the Exynos 8895 SoC and also >> initial board support for Samsung Galaxy S8 phone (SM-G950F), codenamed >> dreamlte. >> >> The Exynos 8895 SoC is also used in S8 Plus (dream2lte), Note 8 (greatlte) >> and Meizu 15 Plus (m1891). Currently DT is added for the Exynos 8895 SoC >> and dreamlte, but it should be really easy to adapt for the other devices >> with the same SoC. > How did you resolve this comment: > > "I do not believe this was tested. See maintainer SoC profile for > Samsung Exynos." > > ? > - Fixed suffixes for the exynos8895 pinctrl device tree It seems, however, that I've left a few nodes improper. $ make CHECK_DTBS=y ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- exynos/exynos8895-dreamlte.dtb W=1 DTC_CHK arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dtb arch/arm64/boot/dts/exynos/exynos8895.dtsi:175.38-186.5: Warning (simple_bus_reg): /soc@0/interrupt-controller@10200000: simple-bus unit address format error, expected "10201000" /home/ivaylo/linux/s8/for-upstream/linux/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dtb: pinctrl@11430000: 'sd2-clk_fast_slew_rate_1x-pins', 'sd2-clk_fast_slew_rate_2x-pins', 'sd2-clk_fast_slew_rate_3x-pins', 'sd2-clk_fast_slew_rate_4x-pins' do not match any of the regexes: '^(initial|sleep)-state$', '^[a-z0-9-]+-pins$', '^[a-z]+[0-9]*-gpio-bank$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/pinctrl/samsung,pinctrl.yaml# /home/ivaylo/linux/s8/for-upstream/linux/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dtb: pinctrl@164b0000: gpa1-gpio-bank:#interrupt-cells:0:0: 2 was expected from schema $id: http://devicetree.org/schemas/pinctrl/samsung,pinctrl.yaml# /home/ivaylo/linux/s8/for-upstream/linux/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dtb: pinctrl@164b0000: 'key-power', 'key-voldown', 'key-volup', 'key-wink', 'pcie_wake-pins', 'wlan_host_wake-pins' do not match any of the regexes: '^(initial|sleep)-state$', '^[a-z0-9-]+-pins$', '^[a-z]+[0-9]*-gpio-bank$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/pinctrl/samsung,pinctrl.yaml# I'll ensure this is properly tested and fixed next time. Thanks for the quick response and best regards, Ivaylo
