On 03/09/2024 09:00, Xianwei Zhao via B4 Relay wrote: > From: Yiting Deng <yiting.deng@xxxxxxxxxxx> > > Add documentation describing the Amlogic A4(A113L2) and A5(A113X2) > rtc controller. RTC. And no "controller". > > Signed-off-by: Yiting Deng <yiting.deng@xxxxxxxxxxx> > Signed-off-by: Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx> > --- > .../bindings/rtc/amlogic,amlogic-rtc.yaml | 66 ++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/amlogic,amlogic-rtc.yaml b/Documentation/devicetree/bindings/rtc/amlogic,amlogic-rtc.yaml > new file mode 100644 > index 000000000000..128c60b623e1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/amlogic,amlogic-rtc.yaml That's odd filename. Use compatible as the filename. > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2024 Amlogic, Inc. All rights reserved > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/amlogic,amlogic-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic Real Time Clock controller include a4, a5 Sorry, that's unparseable. Either this is clock controller or RTC. What does it mean "include a4"? > + > +maintainers: > + - Yiting Deng <yiting.deng@xxxxxxxxxxx> > + - Xianwei Zhao <xianwei.zhao@xxxxxxxxxxx> > + > +description: > + The Amlogic new chips used RTC module. This tells me nothing. Please say something useful or drop this. Best regards, Krzysztof
