Re: [PATCH v2 3/6] dt-bindings: phy: mxs-usb-phy: add nxp,sim property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 03, 2024 at 09:08:52AM +0200, Greg KH wrote:
> On Thu, Aug 29, 2024 at 05:09:35PM +0800, Xu Yang wrote:
> > Hi Greg,
> > 
> > On Fri, Jul 26, 2024 at 07:32:04PM +0800, Xu Yang wrote:
> > > i.MX7ULP need properly set System Integration Module(SIM) module to make
> > > usb wakeup work well. This will add a "nxp,sim" property.
> > > 
> > > Signed-off-by: Xu Yang <xu.yang_2@xxxxxxx>
> > > 
> > > ---
> > > Changes in v2:
> > >  - add else branch suggested by Rob
> > > ---
> > >  .../devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 17 +++++++++++++++++
> > >  1 file changed, 17 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > > index f4b1ca2fb562..ce665a2779b7 100644
> > > --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> > > @@ -87,6 +87,12 @@ properties:
> > >      maximum: 119
> > >      default: 100
> > >  
> > > +  nxp,sim:
> > > +    description:
> > > +      The system integration module (SIM) provides system control and chip
> > > +      configuration registers.
> > > +    $ref: /schemas/types.yaml#/definitions/phandle
> > > +
> > >  required:
> > >    - compatible
> > >    - reg
> > > @@ -110,6 +116,17 @@ allOf:
> > >        required:
> > >          - fsl,anatop
> > >  
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          const: fsl,imx7ulp-usbphy
> > > +    then:
> > > +      required:
> > > +        - nxp,sim
> > > +    else:
> > > +      properties:
> > > +        nxp,sim: false
> > > +
> > >  additionalProperties: false
> > >  
> > >  examples:
> > 
> > 
> > Could you please pick up patch #3? Rest of the patches are mainlined.
> 
> Can you please resend it as an individual patch with the reviewed-by
> added to it?

Sure. Will do it later.

Thanks,
Xu Yang




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux