Hi, Qunqin, On Tue, Sep 3, 2024 at 9:53 AM Zhao Qunqin <zhaoqunqin@xxxxxxxxxxx> wrote: > > add device tree bindings for ls3a5000 EDAC driver. For dt-binding, of course I'm not as familiar as Krzysztof, but I think Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml is a good example.So maybe the file name can be Documentation/devicetree/bindings/edac/loongson,ls3a-mc-edac.yaml? In addition, I don't see any differences for different processors in the driver, so maybe it can be more generic as Documentation/devicetree/bindings/edac/loongson,ls3x-mc-edac.yaml? > > Signed-off-by: Zhao Qunqin <zhaoqunqin@xxxxxxxxxxx> > --- > .../edac/loongson,ls3a5000-mc-edac.yaml | 44 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml > > diff --git a/Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml b/Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml > new file mode 100644 > index 000000000..52f10bc94 > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/edac/loongson,ls3a5000-mc-edac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson Memory Controller EDAC > + > +maintainers: > + - Zhao Qunqin <zhaoqunqin@xxxxxxxxxxx> > + > +description: | > + EDAC node is defined to describe on-chip error detection and correction for > + Loongson Memory Controller. > + > +properties: > + compatible: > + oneOf: > + - enum: > + - loongson,ls3a5000-mc-edac Maybe we can use loongson,ls3a-mc-edac or loongson,ls3x-mc-edac as the only name here. But please follow Krzysztof's suggestion first. Huacai > + - items: > + - enum: > + - loongson,ls3c5000l-mc-edac > + - loongson,ls3c5000-mc-edac > + - loongson,ls3d5000-mc-edac > + - loongson,ls3a6000-mc-edac > + - loongson,ls3c6000-mc-edac > + - const: loongson,ls3a5000-mc-edac > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + memory-controller@1fe00600 { > + compatible = "loongson,ls3a5000-mc-edac"; > + reg = <0x1fe00600 0x50>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 42decde38..6cc8cfc8f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -13237,6 +13237,12 @@ S: Maintained > F: Documentation/devicetree/bindings/thermal/loongson,ls2k-thermal.yaml > F: drivers/thermal/loongson2_thermal.c > > +LOONGSON EDAC DRIVER > +M: Zhao Qunqin <zhaoqunqin@xxxxxxxxxxx> > +L: linux-edac@xxxxxxxxxxxxxxx > +S: Maintained > +F: Documentation/devicetree/bindings/edac/loongson,ls3a5000-mc-edac.yaml > + > LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) > M: Sathya Prakash <sathya.prakash@xxxxxxxxxxxx> > M: Sreekanth Reddy <sreekanth.reddy@xxxxxxxxxxxx> > -- > 2.43.0 >
