On 2.09.2024 6:01 PM, neil.armstrong@xxxxxxxxxx wrote: > On 02/09/2024 16:50, Konrad Dybcio wrote: >> From: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx> >> >> The USB MP controller is wired up to the USB-A port on the left side >> and to the Surface Connector on the right side. Configure it. >> >> While at it, remove a stray double \n. >> >> Signed-off-by: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx> >> --- >> .../boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 59 +++++++++++++++++++++- >> 1 file changed, 57 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi >> index 5419d0b02785..ac2acf949b70 100644 >> --- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi >> +++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi >> @@ -572,7 +572,17 @@ &i2c5 { >> status = "okay"; >> - /* Something @4f */ >> + ptn3222: redriver@4f { >> + compatible = "nxp,ptn3222"; >> + reg = <0x4f>; >> + >> + reset-gpios = <&tlmm 7 GPIO_ACTIVE_LOW>; >> + >> + vdd3v3-supply = <&vreg_l13b>; >> + vdd1v8-supply = <&vreg_l4b>; >> + >> + #phy-cells = <0>; > > It's unrelated to mutiport USB-A, should go in a separate change, > and also probably in a bigger change enabling usb-c features using > the retimer. No, this chip converts between eUSB on the PHY and USB on the port Konrad