On Mon, Sep 02, 2024 at 07:07:02AM +0000, Tarang Raval wrote: > Hi, > > >> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > >> + - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board > >> - const: fsl,imx8mp > > > ><form letter> > >This is a friendly reminder during the review process. > > > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp." ??? No, there is no difference. You did not test your patches either. When I wrote "This is not correct", it means you should drop it. Incorrect compatibles should not be added. Best regards, Krzysztof
