Hi Krzysztof, On Sat, Aug 31, 2024 at 3:23 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > No, this does not look correct. Why suddenly all devices get CPHA/CPOL? > This is supposed to be only for devices REALLY needing it (as discussed > with patch moving it out of spi-peripheral-props, did anything change > here?). I tried like to apply spi-cpha and spi-cpol only to elgin,jg10309-01: --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -419,6 +419,17 @@ properties: - vicor,pli1209bc # Winbond/Nuvoton H/W Monitor - winbond,w83793 +allOf: + - if: + properties: + compatible: + contains: + enum: + - elgin,jg10309-01 + then: + properties: + spi-cpha: true + spi-cpol: true required: - compatible but that did not help: $ make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb -j12 DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb /home/fabio/linux-next/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# I would appreciate a suggestion on how to fix the warning. Thanks