Re: [PATCH] arm64: dts: ti: k3-am642-evm-nand: Rename pinctrl node and gpio-hog names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Aug 30, 2024 at 05:27:09 -0500, Nishanth Menon wrote:
> Rename the pin mux and gpio-hog node names to match up with binding
> rules. This fixes dtbs_check warnings:
> 'gpmc0-pins-default' does not match any of the regexes: '-pins(-[0-9]+)?$|-pin$', 'pinctrl-[0-9]+'
> 'gpio0-36' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
> 
> Signed-off-by: Nishanth Menon <nm@xxxxxx>
> ---
> Cc: Roger Quadros <rogerq@xxxxxxxxxx>
> 
> This is a trivial fix, so applying Fixes seemed over-board.
> 
>  arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> index f08c0e272b53..f91589818e32 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> @@ -12,7 +12,7 @@
>  #include "k3-pinctrl.h"
>  
>  &main_pmx0 {
> -	gpmc0_pins_default: gpmc0-pins-default {
> +	gpmc0_pins_default: gpmc0-default-pins {

I mean, if you are anyway renaming,
s/gpmc0_pins_default/gpmc0_default_pins

>  		bootph-all;
>  		pinctrl-single,pins = <
>  			AM64X_IOPAD(0x0094, PIN_INPUT, 7) /* (T19) GPMC0_BE1n.GPIO0_36 */
> @@ -50,7 +50,7 @@ AM64X_IOPAD(0x00a4, PIN_OUTPUT, 0) /* (N17) GPMC0_DIR */
>  };
>  
>  &main_gpio0 {
> -	gpio0-36 {
> +	gpmc0-hog {
>  		bootph-all;
>  		gpio-hog;
>  		gpios = <36 0>;

With the change,
Reviewed-by: Dhruva Gole <d-gole@xxxxxx>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux