Re: [PATCH v3 4/5] media: staging: max96712: Document the DEBUG_EXTRA register

Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> · Fri, 30 Aug 2024 10:15:52 +0200

Hi Niklas,

On Thu, Aug 29, 2024 at 6:52 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> The DEBUG_EXTRA register is not part of soon to be added MAX96724
> device. To make it easier to understand the differences when reading the
> code prepare for the addition by creating named defines for the
> register.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> * Changes since v2
> - New in v3.

Thanks for your patch!

> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -16,6 +16,10 @@
>  #include <media/v4l2-fwnode.h>
>  #include <media/v4l2-subdev.h>
>
> +#define DEBUG_EXTRA_REG                        0x09
> +#define DEBUG_EXTRE_PCLK_25MHZ         0x00
> +#define DEBUG_EXTRE_PCLK_75MHZ         0x01

s/EXTRE/EXTRA/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds