On 29-08-24, 09:38, Inochi Amaoto wrote: > On Wed, Aug 28, 2024 at 11:24:24PM GMT, Vinod Koul wrote: > > On 27-08-24, 14:49, Inochi Amaoto wrote: > > > The "top" system controller of CV18XX/SG200X exposes control > > > register access for various devices. Add soc header file to > > > describe it. > > > > I dont think I am full onboard this idea, > > Feel free to share your idea. I just added this file for > convenience to access the offset of the syscon device. > In fact, I am not sure whether it is better to use reg > offset. Using reg adds some unncessary complexity, but > can avoid use this offset file. If you prefer this way, > it is OK for me to change. I would just add the offsets that I need in local driver header and move on... > > > but still need someone to ack it > > I am not sure there will be someone to ack it. If this patch > is kept. > > > > > > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxxxx> > > > --- > > > include/soc/sophgo/cv1800-sysctl.h | 30 ++++++++++++++++++++++++++++++ > > > > is soc/sophgo/ right path? why not include/soc/sifive/... (sorry dont > > know much about this here...) > > > > CV1800 is a SoC from Sophgo, it is not from SiFive. As I said I am not sure, someone who is from this world should ack this header -- ~Vinod
