On 8/29/2024 12:36 AM, Krzysztof Kozlowski wrote: > On Wed, Aug 28, 2024 at 01:37:13PM -0700, Nikunj Kela wrote: >> Add compatible for smmu representing support on SA8255p. >> >> Signed-off-by: Nikunj Kela <quic_nkela@xxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> > Your subjects contain quite redundant/excessive information. In the same > time they lack information about device. > > 1. s/document the support on/add/ > 2. s/SA8255p/SA8255p SMMU-or-whatever-device-it-is/ > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof Okay. I thought arm-smmu tag already indicate which device this patch is for but would put SMMU explicitly in the subject. Thanks, -Nikunj
