Hi Jonathan, Am Mittwoch, 28. August 2024, 15:24:56 CEST schrieb Jonathan Liu: > On Wed, 28 Aug 2024 at 22:59, Heiko Stübner <heiko@xxxxxxxxx> wrote: > > Am Mittwoch, 28. August 2024, 09:47:53 CEST schrieb Jonathan Liu: > > > This adds the necessary device tree changes to enable analog audio > > > output for the 3.5 mm TRS headphone jack on the Radxa ROCK 4C+ with > > > its RK809 audio codec. > > > > > > Signed-off-by: Jonathan Liu <net147@xxxxxxxxx> > > > > as it looks like you have one of those boards, could I possibly as you > > to take a look at the vdd_cpu_b and vdd_gpu nodes? > > > > I see (and devicetree check reports it too) a pinctrl-0 for the vsel-gpio > > without accompanying pinctrl-names. > > > > Could you check if things fail if you either add pinctrl-names or remove > > the pinctrl-0 entry? > > I tried both but neither resulted in any change to the warnings in dtbs_check. > Reverting my change also results in the same warnings so I don't think > it is related to my change. I was more aiming at a functional test on the board :-) . You are correct in that this is not related to your change, I was just seeing someone with the hardware. I.e. while running dtbs check here I saw those regulator nodes and didn't want to change stuff without being able to test them. Heiko
