Re: [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2024/8/28 21:02, Krzysztof Kozlowski wrote:
On 28/08/2024 10:45, Jacobe Zang wrote:
Wi-Fi compatible in these DTS is based on PCI ID. Bindings need
"brcm,bcm4329-fmac" as fallback compatible.

Signed-off-by: Jacobe Zang <jacobe.zang@xxxxxxxxxx>
---
  arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +-
  arch/arm64/boot/dts/apple/t8112-j413.dts  | 2 +-
  arch/arm64/boot/dts/apple/t8112-j493.dts  | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)


Bindings are being questioned, so link to them in changelog section
would help the maintainers to decide when to apply it.

I am not convinced this is correct bindings change, thus this DTS should
wait.

Your previous patch also misses link to bindings. Whenever you split DTS
to separate series, please always provide link to the bindings, so
people will have the context.


Sure.  I will post the link in changelog next time.

--
Best Regards
Jacobe




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux