在 8/28/2024 3:57 PM, Krzysztof Kozlowski 写道:
On 28/08/2024 09:42, Lijuan Gao wrote:
在 8/28/2024 2:23 PM, Krzysztof Kozlowski 写道:
On Wed, Aug 28, 2024 at 10:02:15AM +0800, Lijuan Gao wrote:
Add initial DTSI for QCS615 SoC. It includes base description
of CPUs, interrupt-controller and cpu idle on Qualcomm QCS615
platform.
Signed-off-by: Lijuan Gao <quic_lijuang@xxxxxxxxxxx>
---
arch/arm64/boot/dts/qcom/qcs615.dtsi | 449 +++++++++++++++++++++++++++++++++++
1 file changed, 449 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
new file mode 100644
index 000000000000..cf7aaa7f6131
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
@@ -0,0 +1,449 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+
+/ {
+ interrupt-parent = <&intc>;
+
No need for blank line.
Well noted. Will update in the next patch.
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ chosen { };
Drop, redundant.
Well noted. Will update in the next patch.
+
+ clocks {
+ xo_board: xo-board {
xo-clk? xo-board-clk?
But if board, this does not sound like part of SoC. See other files how
they do it.
Other files also added ‘xo_board’. The ‘xo_board’ is the clock that will
No. Don't use 10yo code as example.
be used by other SoC nodes, such as rpmhcc. Currently, the node can be
deleted as no one is using it.
I don't think you understood the problem. This is not the property of
SoC. We talked about this many times. DTS coding style has even explicit
guideline for this. Your own go/upstream (which is quite well written
and complete) probably as well. Did you check it? If there is no such,
extend it.
Got it, I will move it to the board DTS.
Best regards,
Krzysztof
--
Thx and BRs
Lijuan Gao
