On 8/27/24 18:37, Marek Vasut wrote: > Do not use wilc_get_chipid() outside of wlan.c . Instead, call > wilc_get_chipid() right after the SDIO/SPI interface has been > initialized to cache the device chipid, and then use the cached > chipid throughout the driver. Make wilc_get_chipid() static and > remove its prototype from wlan.h . Make wilc_get_chipid() return > a proper return value instead of a chipid. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > --- > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: Adham Abozaeid <adham.abozaeid@xxxxxxxxxxxxx> > Cc: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> > Cc: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> > Cc: Claudiu Beznea <claudiu.beznea@xxxxxxxxx> > Cc: Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx> > Cc: Kalle Valo <kvalo@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx> > Cc: Marek Vasut <marex@xxxxxxx> > Cc: Paolo Abeni <pabeni@xxxxxxxxxx> > Cc: Rob Herring <robh@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-wireless@xxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx nit: The remaining wilc_getchipid() call in netdev.c should have been removed in this very same commit (it is removed in a later patch in this series, but it makes this commit depend on the last one). Reviewed-by: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
