On Mon, Aug 26, 2024 at 4:44 PM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote: > The ISP Channel Selector IP is the same for all current Gen4 devices. > This was not known when adding support for V3U and V4H and a single SoC > specific compatible was used. > > Before adding more SoC specific bindings for V4M add a family compatible > fallback for Gen4. That way the driver only needs to be updated once for > Gen4, and we still have the option to fix any problems in the driver if > any testable differences between the SoCs are found. > > There are already DTS files using the V3U and V4H compatibles which > needs to be updated to not produce a warning for DTS checks. The driver > also needs to kept the compatible values to be backward compatible , but > for new Gen4 SoCs such as V4M we can avoid this. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > * Changes since v1 > - New in v2. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> This is in line with Section 2.3.1 ("Standard Properties / Compatible") of the Devicetree Specification, Release v0.4, as it is used "to express compatibility with a family of similar devices". Note that this does deviate slightly from the recommended format in the specification ("manufacturer,model"), as the fallback "model" specifies a family, not a model number. As such I think this is fine, and consistent with lots of other existing family-specific compatible values. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds