On Sun, Mar 08, 2015 at 01:51:51AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Saturday 07 March 2015 23:41:13 Sakari Ailus wrote:
> > The resources the ISP needs are slightly different on 3[45]xx and 3[67]xx.
> > Especially the phy-type property is different.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> > ---
> > arch/arm/boot/dts/omap34xx.dtsi | 15 +++++++++++++++
> > arch/arm/boot/dts/omap36xx.dtsi | 15 +++++++++++++++
> > 2 files changed, 30 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/omap34xx.dtsi
> > b/arch/arm/boot/dts/omap34xx.dtsi index 3819c1e..4c034d0 100644
> > --- a/arch/arm/boot/dts/omap34xx.dtsi
> > +++ b/arch/arm/boot/dts/omap34xx.dtsi
> > @@ -37,6 +37,21 @@
> > pinctrl-single,register-width = <16>;
> > pinctrl-single,function-mask = <0xff1f>;
> > };
> > +
> > + omap3_isp: omap3_isp@480bc000 {
> > + compatible = "ti,omap3-isp";
> > + reg = <0x480bc000 0x12fc
> > + 0x480bd800 0x017c>;
> > + interrupts = <24>;
> > + iommus = <&mmu_isp>;
> > + syscon = <&omap3_scm_general 0xdc>;
> > + ti,phy-type = <0>;
> > + #clock-cells = <1>;
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> How about predefining the ports too ?
After a short discussion, we decided not to add port nodes. The arguments
considered were:
- Port nodes could help integrators writing the DT nodes. However the port
nodes are easier to construct than endpoint nodes. Board specific
configuration would also still need to be added.
- Extra port nodes take space which could be spent more usefully for other
purposes.
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
