On Tue, Aug 27, 2024 at 03:18:41PM +0200, Niklas Söderlund wrote: > @@ -181,7 +186,8 @@ static void max96712_pattern_enable(struct max96712_priv *priv, bool enable) > } > > /* PCLK 75MHz. */ > - max96712_write(priv, 0x0009, 0x01); > + if (!priv->max96724) > + max96712_write(priv, 0x0009, 0x01); > I don't like this either. The comment should move. I didn't see the ! the first couple times I read this. I don't like the MAX96712_ID and MAX96724_ID defines because when humans read they only see the general shape of the words. https://www.dictionary.com/e/typoglycemia/ https://en.wikipedia.org/wiki/Hamming_distance I guess the best we can do is remove the _ID so at least the last characters are different. It should be something like: if (priv->id == MAX96712) { /* PCLK 75MHz. */ max96712_write(priv, 0x0009, 0x01); } Or maybe put in function. regards, dan carpenter
