Hi Niklas,
> -----Original Message-----
> From: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> Sent: Tuesday, August 27, 2024 9:14 AM
> Subject: Re: [PATCH v2 4/6] media: rcar-isp: Add family compatible for R-Car Gen4 family
>
> Hello Biju,
>
> Thanks for your feedback.
>
> On 2024-08-26 14:48:07 +0000, Biju Das wrote:
> > Hi Niklas Söderlund,
> >
> > Thanks for the patch.
> >
> > > -----Original Message-----
> > > From: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > > Sent: Monday, August 26, 2024 3:44 PM
> > > Subject: [PATCH v2 4/6] media: rcar-isp: Add family compatible for
> > > R-Car Gen4 family
> > >
> > > Add the Gen4 family compatible. This will be used instead of a SoC
> > > specific compatible for the new
> > > Gen4 SoC V4M. Two Gen4 boards (V3U and
> > > V4H) have already been added prior and their bindings need to be kept for backward compatibility.
> > >
> > > Signed-off-by: Niklas Söderlund
> > > <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > > ---
> > > * Changes since v1
> > > - Reworked to add a family compatible instead of V4M specific one.
> > > ---
> > > drivers/media/platform/renesas/rcar-isp.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/media/platform/renesas/rcar-isp.c
> > > b/drivers/media/platform/renesas/rcar-isp.c
> > > index 4512ac338ca5..6504c7025a40 100644
> > > --- a/drivers/media/platform/renesas/rcar-isp.c
> > > +++ b/drivers/media/platform/renesas/rcar-isp.c
> > > @@ -429,8 +429,11 @@ static int risp_probe_resources(struct rcar_isp
> > > *isp, }
> > >
> > > static const struct of_device_id risp_of_id_table[] = {
> > > + /* Keep to be compatible with old DTS files. */
> > > { .compatible = "renesas,r8a779a0-isp" },
> > > + /* Keep to be compatible with old DTS files. */
> > > { .compatible = "renesas,r8a779g0-isp" },
> > > + { .compatible = "renesas,rcar-gen4-isp" },
> > > { /* sentinel */ },
> >
> > Nit pick:
> > Comma can be dropped from last entry.
>
> Indeed it could be dropped from the "sentinel" entry, but that would be a different patch.
Agreed, It is a separate patch. since you are touching this part,I got similar comment
in one of patches as "removing the trailing comma in the terminator entry for the ID
table making code robust against (theoretical) misrebases or other
similar things where the new entry goes _after_ the termination without
the compiler noticing."
Cheers,
Biju
>
> >
> > Cheers,
> > Biju
> >
> > > };
> > > MODULE_DEVICE_TABLE(of, risp_of_id_table);
> > > --
> > > 2.45.2
> > >
> >
>
> --
> Kind Regards,
> Niklas Söderlund
