On 27/08/2024 10:42, Lukasz Majewski wrote:
> The description for imx28 based devices needs to be updated after some
> further development.
Everything is an update, please be specific in commit subject and message.
>
> Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
> ---
> arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi | 38 +++++++++---------------
> 1 file changed, 14 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi b/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
> index 69fcb0dde940..6fa1f3e25b08 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28-lwe.dtsi
> @@ -55,23 +55,6 @@ &i2c0 {
> status = "okay";
> };
>
> -&saif0 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&saif0_pins_a>;
> - #sound-dai-cells = <0>;
> - assigned-clocks = <&clks 53>;
> - assigned-clock-rates = <12000000>;
> - status = "okay";
> -};
> -
> -&saif1 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&saif1_pins_a>;
> - fsl,saif-master = <&saif0>;
> - #sound-dai-cells = <0>;
> - status = "okay";
> -};
> -
> &spi3_pins_a {
> fsl,pinmux-ids = <
> MX28_PAD_AUART2_RX__SSP3_D4
> @@ -109,7 +92,7 @@ &ssp3 {
>
> flash@0 {
> compatible = "jedec,spi-nor";
> - spi-max-frequency = <40000000>;
> + spi-max-frequency = <20000000>;
> reg = <0>;
>
> partitions {
> @@ -133,14 +116,21 @@ partition@90000 {
> reg = <0x90000 0x10000>;
> };
>
> - partition@100000 {
> - label = "kernel";
> - reg = <0x100000 0x400000>;
> + partition@3 {
This does not look right. It is neither explained in commit msg, nor
matching reg.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
> + label = "rescue";
> + reg = <0xA0000 0xF40000>;
Lowercase hex
> + };
> +
Best regards,
Krzysztof
