Hi Prabhakar,
On Wed, Aug 21, 2024 at 10:56 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Add WDT0-WDT3 nodes to RZ/V2H(P) ("R9A09G057") SoC DTSI.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> v2->v3
> - Grouped WDT nodes
Thanks for the update!
> --- a/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g057.dtsi
> @@ -201,6 +201,50 @@ ostm3: timer@14001000 {
> status = "disabled";
> };
>
> + wdt0: watchdog@11c00400 {
> + compatible = "renesas,r9a09g057-wdt";
> + reg = <0 0x11c00400 0 0x400>;
> + clocks = <&cpg CPG_MOD 75>,
> + <&cpg CPG_MOD 76>;
> + clock-names = "pclk", "oscclk";
> + resets = <&cpg 117>;
> + power-domains = <&cpg>;
> + status = "disabled";
> + };
> +
> + wdt2: watchdog@13000000 {
Usually we sort the instances within a group by instance number, i.e.
wdt0: watchdog@11c00400 {
wdt1: watchdog@14400000 {
wdt2: watchdog@13000000 {
wdt3: watchdog@13000400 {
See e.g. the scif nodes in arch/arm64/boot/dts/renesas/r8a77951.dtsi:
scif0: serial@e6e60000 {
scif1: serial@e6e68000 {
scif2: serial@e6e88000 {
scif3: serial@e6c50000 {
scif4: serial@e6c40000 {
scif5: serial@e6f30000 {
scif3 and scif4 have lower base addresses than scif0.
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
