Re: [PATCH v4 1/4] iio: magnetometer: ak8975: Relax failure on unknown id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 26, 2024 at 11:39:20AM +0100, Jonathan Cameron wrote:
> On Fri, 23 Aug 2024 22:11:15 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Aug 23, 2024 at 07:32:03PM +0100, Jonathan Cameron wrote:
> > > On Mon, 19 Aug 2024 00:29:39 +0200
> > > Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx> wrote:  

...

> > > > +	/* Let driver to probe on unknown id for support more register  
> > > Comment style wrong, I'll fix it up.
> > > 
> > > With that tweak applied to the togreg branch of iio.git

> > > > +	 * compatible variants.
> > > > +	 */  
> > 
> > There is another one also wrong.
> > 
> > +	[AK09918] = {
> > +		/* ak09918 is register compatible with ak09912 this is for avoid
> > +		 * unknown id messages.
> > +		 */
> 
> I think unrelated to this series, but nice to cleanup.
> Patches welcome :)

Sure, but I leave this to newbies to have a material to exercise on.

> Or it I get bored, I might do a scrub of the full subsystem to get everything
> in the same style and not provide incorrect choices to cut and paste.

:-)

I believe we still have more interesting cases, than white space cleanups.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux