On 03/13/2015 01:05 PM, Arnd Bergmann wrote: > On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: >> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> index 1ab6bc8..656165f 100644 >> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> @@ -4,7 +4,6 @@ Required properties: >> - compatible: "ti,omap-twl4030" >> - ti,model: Name of the sound card (for example "omap3beagle") >> - ti,mcbsp: phandle for the McBSP node >> -- ti,codec: phandle for the twl4030 audio node > > As this was a required property, are you sure that no other operating system > uses it? > > Even if not, you should probably change it to be an optional property, so > that the existing dtbs do not become noncompliant after the change. After I sent my Ack, I also started to think about the same thing. It is better to change it to optional. -- Péter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
