Re: [PATCH v2 22/36] soc: fsl: cpm1: qmc: Add missing spinlock comment

[Christophe Leroy <christophe.leroy@xxxxxxxxxx>]

Le 08/08/2024 à 09:11, Herve Codina a écrit :
> checkpatch.pl raises the following issue
>    CHECK: spinlock_t definition without comment
>
> Add the missing comments.
>
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>

Reviewed-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>

> ---
>   drivers/soc/fsl/qe/qmc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 2d54d7400d2d..3736a8e4575e 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -196,7 +196,7 @@ struct qmc_chan {
>   	u64	rx_ts_mask;
>   	bool is_reverse_data;
>   
> -	spinlock_t	tx_lock;
> +	spinlock_t	tx_lock; /* Protect Tx related data */
>   	cbd_t __iomem *txbds;
>   	cbd_t __iomem *txbd_free;
>   	cbd_t __iomem *txbd_done;
> @@ -204,7 +204,7 @@ struct qmc_chan {
>   	u64	nb_tx_underrun;
>   	bool	is_tx_stopped;
>   
> -	spinlock_t	rx_lock;
> +	spinlock_t	rx_lock; /* Protect Rx related data */
>   	cbd_t __iomem *rxbds;
>   	cbd_t __iomem *rxbd_free;
>   	cbd_t __iomem *rxbd_done;