On 23/08/2024 03:38, Marek Vasut wrote: > On 8/22/24 10:07 AM, Krzysztof Kozlowski wrote: > > Hi, > >>> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml >>> index 2460ccc082371..1bf3496c21e64 100644 >>> --- a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml >>> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml >>> @@ -16,7 +16,9 @@ description: >>> >>> properties: >>> compatible: >>> - const: microchip,wilc1000 >>> + enum: >>> + - microchip,wilc1000 >>> + - microchip,wilc3000 >> >> Your driver change suggests device type is fully auto-detectable > > It seems that way, yes. > >> , thus >> they are compatible. > > I _think_ the hardware is internally somewhat different, the WILC1000 is > WiFi-only device and the WILC3000 has some extra Bluetooth part (which > is currently not supported). > > Maybe a fallback compatible string would be better here ? Yes, that's what I meant by compatibility. 3000 followed by 1000. Best regards, Krzysztof
