> Subject: [PATCH net-next v4 2/2] net: dsa: microchip: Add KSZ8895/KSZ8864 switch
> support
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content
> is safe
>
> Hi Tristram,
>
> > @@ -325,7 +327,7 @@ void ksz8_r_mib_pkt(struct ksz_device *dev, int port, u16
> addr,
> >
> > void ksz8_freeze_mib(struct ksz_device *dev, int port, bool freeze)
> > {
> > - if (ksz_is_ksz88x3(dev))
> > + if (ksz_is_ksz88x3(dev) || ksz_is_8895_family(dev))
>
> Small comment, would it not be more clear and consistent to introduce
> a new ksz_is_ksz88xx function in ksz_common.h, being ksz_is_ksz88x3 ||
> ksz_is_8895_family?
>
> That would help with the renamed ksz88x3_dev_ops that you will
> encounter when rebasing. In fact, seeing your additions here, I would
> propose to rename this struct to ksz88xx_dev_ops.
Will update and re-submit patches after testing with new code.
