On Thu, Aug 22, 2024 at 9:28 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > On Tue, Aug 13, 2024 at 09:15:06PM +0200, Bartosz Golaszewski wrote: > > On Sat, Aug 3, 2024 at 5:23 AM Krishna chaitanya chundru > > <quic_krichai@xxxxxxxxxxx> wrote: > > > > > > Currently the pwrctl driver is child of pci-pci bridge driver, > > > this will cause issue when suspend resume is introduced in the pwr > > > control driver. If the supply is removed to the endpoint in the > > > power control driver then the config space access by the > > > pci-pci bridge driver can cause issues like Timeouts. > > > > > > For this reason change the parent to controller from pci-pci bridge. > > > > > > Fixes: 4565d2652a37 ("PCI/pwrctl: Add PCI power control core code") > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@xxxxxxxxxxx> > > > --- > > > > Tested-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > Bjorn, > > > > I think this should go into v6.11 as it does indeed better represent > > the underlying logic. > > Is this patch independent of the rest? I don't think the whole series > looks like v6.11 material, but if this patch can be applied > independently, *and* we can make a case in the commit log for why it > is v6.11 material, we can do that. > > Right now the commit log doesn't tell me enough to justify a > post-merge window change. > > Bjorn Please, apply this patch independently. FYI I have a WiP branch[1] with a v3 of the fixes series rebased on top of this one. Manivannan and I are working on fixing one last remaining issue and I'll resend it. This should go into v6.11. Bart [1] https://git.codelinaro.org/bartosz_golaszewski/linux/-/tree/topic/pci-pwrctl-fixes