On Fri, Mar 13, 2015 at 12:23:27AM +0200, Sakari Ailus wrote:
...
> > > +
> > > + for (i = 0; i < ARRAY_SIZE(bus->lane_polarity); i++) {
> > > + polarity = of_prop_next_u32(prop, polarity, &v);
> > > + if (!polarity)
> > > + break;
> > > + bus->lane_polarity[i] = v;
> > > + }
> >
> > Should we check that i == num_data_lines + 1 ?
>
> Good question. I think I'd just replace this with
> of_property_read_u32_array() instead, how about that? Then there would have
> to be at least as many lane polarities defined as there are lanes (data and
> clock). Defining more wouldn't be an error.
Oh, I missed the variable in the struct is bool. I'll just add the check.
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
