On Mon, 19 Aug 2024 06:53:51 +0000 Parthiban.Veerasooran@xxxxxxxxxxxxx wrote: > > This is a bit unusual. If the core decides to drop the packet it will > > count the drop towards the appropriate statistic. The drivers generally > > only count their own drops, and call netif_rx() without checking the > > return value. > > The first version of this patch series didn't have this check. There was > a comment in the 1st version to check the return value and update the > statistics. > > https://lore.kernel.org/lkml/375fa9b4-0fb8-8d4b-8cb5-d8a9240d8f16@xxxxxxxxxx/ > > That was the reason why it was introduced in the v2 of the patch series > itself. It seems, somehow it got escaped from your RADAR from v2 to v5 > :D. Sorry about that :( There's definitely a gap in terms of reviewing the work of reviewers :( > Sorry, somehow I also missed to check it in the netdev core. Now I > understand that the rx drop handled in the core itself in the below link > using the function "dev_core_stats_rx_dropped_inc(skb->dev)". > > https://github.com/torvalds/linux/blob/master/net/core/dev.c#L4894 > > Is my understanding correct? if so then I will remove this check in the > next version. Yes!
