On 19/08/2024 17:32, Mathieu Poirier wrote: >>>> Please remove. >>> Forget this comment since it would cause an error in __rproc_detach(). >>> >>>> Other than the above I'm good with this driver. That said I can't move forward >>>> without a nod from the DT crew. I also noticed a fair amount of code >>>> duplication with the k3_r5 and k3_dsp drivers. Dealing with that should not be >>>> part of the current work but will need to be done before another k3 driver can >>>> be merged. >>>> >> >>> The above still apply though. >> >> Me or Nishanth will pick up the SoC DT patches via TI SoC tree, once the >> driver patches are merged. Feel free to ignore those but queue >> dt-bindings (already has DT maintainers ack) and driver patches via >> rproc tree. >> > > Can you provide a link where the DT maintainers have acknowledged the bindings? The reviewed-by tag serves as acknowledgment as well and the binding patch has it. Conor gave it on some earlier version of the patchset. I did not check if there were any significant changes in the meantime, though. Best regards, Krzysztof
