On Sun, Aug 18, 2024 at 09:58:04PM -0700, Dmitry Torokhov wrote: > Instead of doing conditional logic based on the chip type, define > per-chip parameter structure, and reference it in the match data > (either of_device_id or platform_device_id). > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > --- > drivers/input/keyboard/samsung-keypad.c | 61 +++++++++++++++---------- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof