On 19/08/2024 12:12, vtpieter@xxxxxxxxx wrote: > From: Pieter Van Trappen <pieter.van.trappen@xxxxxxx> > > This allows the switch to disable tagging all together, for the use > case of an unmanaged switch for example. > > Signed-off-by: Pieter Van Trappen <pieter.van.trappen@xxxxxxx> > --- I think this is v2 or v3. Please provide changelog under --- (or in cover letter but there is no cover letter here). Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> --- <form letter> This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 </form letter> Best regards, Krzysztof