Hi Jakub, On 16/08/24 10:35 pm, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, 12 Aug 2024 15:56:10 +0530 Parthiban Veerasooran wrote: >> +static void >> +lan865x_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *info) >> +{ >> + strscpy(info->driver, DRV_NAME, sizeof(info->driver)); >> + strscpy(info->bus_info, dev_name(netdev->dev.parent), >> + sizeof(info->bus_info)); >> +} >> + > > Could you check if deleting this function has any effect? > Core should fill in the basic info automatically, modern > drivers usually only have to fill in FW version, if at all. Ah ok, thanks for the info. I verified the output of "ethtool -i <eth_device>" with and without of this function and as you mentioned, got the same result in both the cases. So I will remove this function in the next version. > > If without the callback ethtool -i doesn't report the right > info, please make sure SET_NETDEV_DEV() gets called. Yes, it is already called in the "oa_tc6_init()" function of drivers/net/ethernet/oa_tc6.c file. Best regards, Parthiban V >