On Fri, 2024-08-16 at 17:23 +0800, Delphine CC Chiu wrote: > Add power sensor for power module reading > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index 09bbbcb192f5..139a09de24cf 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -906,6 +906,11 @@ gpio@23 { > "HSC7_ALERT2_R_N","HSC8_ALERT2_R_N"; > }; > > + power-sensor@40 { > + compatible = "mps,mp5023"; > + reg = <0x40>; > + }; > + This appears to be supported by hmwon but there's no binding for the driver[1]. I'm hesitant to accept it and add more warnings to the Aspeed devicetrees, but at the same time I'm sympathetic to leaving it in. Can you perhaps send a patch for Documentation/devicetree/bindings/trivial-devices.yaml along with this series? Andrew [1]: https://lore.kernel.org/all/20211217155206.GA3015782@xxxxxxxxxxxx/