On 8/16/2024 4:06 AM, Jacobe Zang wrote:
WiFi modules often require 32kHz clock to function. Add support to enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check to the top of brcmf_of_probe. Change function prototypes from void to int and add appropriate errno's for return values that will be send to bus when error occurred.
Looks good to me. Not sure if I should Ack this as my SoB is there as well. If that is not a problem than here it is:
Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Co-developed-by: Ondrej Jirman <megi@xxxxxx> Signed-off-by: Ondrej Jirman <megi@xxxxxx> Co-developed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> Reviewed-by: Sai Krishna <saikrishnag@xxxxxxxxxxx> Signed-off-by: Jacobe Zang <jacobe.zang@xxxxxxxxxx> --- .../broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 +-- .../broadcom/brcm80211/brcmfmac/common.c | 3 +- .../wireless/broadcom/brcm80211/brcmfmac/of.c | 29 +++++++++++++------ .../wireless/broadcom/brcm80211/brcmfmac/of.h | 9 +++--- .../broadcom/brcm80211/brcmfmac/pcie.c | 3 ++ .../broadcom/brcm80211/brcmfmac/sdio.c | 22 +++++++++----- .../broadcom/brcm80211/brcmfmac/usb.c | 3 ++ 7 files changed, 49 insertions(+), 24 deletions(-)
