Re: [PATCH 1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Am Freitag, 16. August 2024, 13:06:37 CEST schrieb FUKAUMI Naoki:
> thank you very much for your review.
> 
> but, I decided not to use "pwm-leds-multicolor" for Radxa E25.
> please ignore this patch series.

What Krzysztof meant was probably more in line of that a commit message
should not explain what the commit does, because that can be seen in the
code.

Instead the commit message should explain why that change is needed.


> really sorry.
> 
> Best regards,
> 
> --
> FUKAUMI Naoki
> Radxa Computer (Shenzhen) Co., Ltd.
> 
> On 8/16/24 14:18, Krzysztof Kozlowski wrote:
> > On 16/08/2024 04:32, FUKAUMI Naoki wrote:
> >> enable "pwm-leds-multicolor" driver.
> > 
> > Why?
> > 
> > Best regards,
> > Krzysztof
> > 
> > 
> 
> 








[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux