On Friday 16 August 2024 at 09:12, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 16/08/2024 08:59, vtpieter@xxxxxxxxx wrote: > > From: Pieter Van Trappen <pieter.van.trappen@xxxxxxx> > > > > Add support for changing the KSZ8 switches tag protocol. In fact > > these devices can only enable or disable the tail tag, so there's > > really only three supported protocols: > > - DSA_TAG_PROTO_KSZ8795 for KSZ87xx > > - DSA_TAG_PROTO_KSZ9893 for KSZ88x3 > > - DSA_TAG_PROTO_NONE > > > > --- a/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/dsa-port.yaml > > @@ -53,6 +53,7 @@ properties: > > enum: > > - dsa > > - edsa > > + - none > > - ocelot > > - ocelot-8021q > > - rtl8_4 > > Please run scripts/checkpatch.pl and fix reported warnings. Then please > run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. > Some warnings can be ignored, especially from --strict run, but the code > here looks like it needs a fix. Feel free to get in touch if the warning > is not clear. Hi Krzysztof, thanks indeed I forgot to run it after my last modifications. I am aware that the dt-binding patch should be separate, I just thought it'd make more sense for this RFC to have these together. > Anyway, what does "none" mean in terms of protocol? Is there a "none" > protocol? Or you mean, disable tagging entirely? Indeed the 'none' protocol is DSA_TAG_PROTO_NONE which means disable tagging entirely. The concept with advantages and disadvantages is well described in the paper with link which i part of the commit message. Cheers, Pieter
