On Thu, Aug 15, 2024 at 12:38 PM Frank Li <Frank.li@xxxxxxx> wrote: > > Rob: > > It may be old topic: > https://lore.kernel.org/lkml/c342562e-f915-a853-c2a8-eecefd94b88d@xxxxxxxxx/T/ Yeah, still no one has figured out how to add that to overlays. > When I try to fix below warning, > > arch/arm64/boot/dts/freescale/imx8mn-tqma8mqnl-mba8mx-usbotg.dtb: sel-usb-hub-hog: {'output-low': True, 'gpio-hog': True, 'gpios': [[1, 0]], 'output-high': True, 'phandle': 108, '$nodename': ['sel-usb-hub-hog']} is valid under each of {'required': ['output-low']}, {'required': ['output-high']} > > both "output-low" and "output-high" two flags exist under one node. It's best to design bindings which can't have invalid combinations, but too late for this one... > When I try to delete "output-high" in dtso file, I found it doesn't work > and dtc have not complain /delete node/ not work for overlay. > > It may cause some problems because people think delete success, but > actually not, espeically some important flags. Perhaps add a warning to dtc. It may have to be just in overlays because there might be reliance on the current silent behavior. Rob
