An USB hub is not a HCD, but an USB device. Fix the referenced schema accordingly. Fixes: bfbf2e4b77e2 ("dt-bindings: usb: Document the Microchip USB2514 hub") Cc: stable@xxxxxxxxxxxxxxx Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> --- As this USB hub also can contain an USB (ethernet) sub device, I copied the subdevice part from usb-hcd.yaml. I had to add 'additionalProperties: true' as well, because I got that warning upon dt_binding_check otherwise: > Documentation/devicetree/bindings/usb/microchip,usb2514.yaml: > ^.*@[0-9a-f]{1,2}$: Missing additionalProperties/unevaluatedProperties constraint I added a Fixes tag to keep this schema aligned in v6.10 stable tree. Changes in v2: * Do not update the example * Adjust comit message accordingly * Add Cc for stable * Collected Krzysztof's R-b * Shorten the SHA1 of the Fixes tag .../devicetree/bindings/usb/microchip,usb2514.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml index 245e8c3ce6699..b14e6f37b2987 100644 --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml @@ -10,7 +10,7 @@ maintainers: - Fabio Estevam <festevam@xxxxxxxxx> allOf: - - $ref: usb-hcd.yaml# + - $ref: usb-device.yaml# properties: compatible: @@ -36,6 +36,13 @@ required: - compatible - reg +patternProperties: + "^.*@[0-9a-f]{1,2}$": + description: The hard wired USB devices + type: object + $ref: /schemas/usb/usb-device.yaml + additionalProperties: true + unevaluatedProperties: false examples: -- 2.34.1